[gstreamer-bugs] [Bug 443081] [wavparse] fails to post error on FLOW_NOT_LINKED

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=443081

  GStreamer | gst-plugins-good | Ver: 0.10.12

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|gst-plugins-base            |gst-plugins-good
         Resolution|                            |FIXED
            Summary|volume plugin goes async    |[wavparse] fails to post
                   |forever                     |error on FLOW_NOT_LINKED
   Target Milestone|HEAD                        |0.10.6




------- Comment #9 from Tim-Philipp Müller  2007-06-08 09:03 UTC -------
Right, my mistake, sorry. Thanks for the log.

This is a bug in the wavparse plugin in gst-plugins-good 0.10.5. It is fixed in
-good CVS though; this is the commit that fixed it:

  2007-02-14  Wim Taymans  <wim at fluendo.com>

    * gst/wavparse/gstwavparse.c: (gst_wavparse_class_init),
    (gst_wavparse_reset), (gst_wavparse_init),
    (gst_wavparse_destroy_sourcepad), (gst_wavparse_fmt),
    (gst_wavparse_parse_file_header), (gst_wavparse_stream_init),
    (gst_wavparse_perform_seek), (gst_wavparse_peek_chunk_info),
    (gst_wavparse_stream_headers), (gst_wavparse_parse_stream_init),
    (gst_wavparse_add_src_pad), (gst_wavparse_stream_data),
    (gst_wavparse_loop), (gst_wavparse_chain),
    (gst_wavparse_pad_convert), (gst_wavparse_pad_query),
    (gst_wavparse_srcpad_event), (gst_wavparse_change_state),
    (plugin_init):
    * gst/wavparse/gstwavparse.h:
      Update docs.
      Use boilerplate.
      Various code cleanups.
      When the bitrate is not known (bps == 0 or compressed formats) let
      downstream element guestimate the duration and position and don't
      generate timestamps or durations. Fixes #405213.
      Fix EOS and ERROR conditions in chain mode, we just need to forward the
      error flowreturn upstream.


The problem was that wavparse would only post an error message if
GST_FLOW_IS_FATAL(), which does not include GST_FLOW_NOT_LINKED, so it would
just silently pause the streaming task and the application would never know
that streaming stopped.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=443081.