[gstreamer-bugs] [Bug 446763] [identity] leaks events in single segment mode

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=446763

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|add event unref inside      |[identity] leaks events in
                   |identity                    |single segment mode




------- Comment #2 from Tim-Philipp Müller  2007-06-12 15:48 UTC -------
I don't think the GstBaseTransformClass::event vfunc is supposed to ever take
ownership of the event. Seems more likely to me that
gst_base_transform_sink_event() is missing a

  if (ret)
    ret = gst_pad_push_event (trans->srcpad, event);
+ else
+   gst_event_unref (event);

otherwise ownership semantics would be a bit weird IMHO.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=446763.