[gstreamer-bugs] [Bug 446981] New: error during the compilation of rtspconnection.c

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=446981

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: error during the compilation of rtspconnection.c
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: vtorri at univ-evry.fr
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


with MinGW, I have those errors:

rtspconnection.c: In function `rtsp_connection_connect':
rtspconnection.c:214: warning: implicit declaration of function `fcntl'
rtspconnection.c:214: error: `F_SETFL' undeclared (first use in this function)
rtspconnection.c:214: error: (Each undeclared identifier is reported only once
rtspconnection.c:214: error: for each function it appears in.)
rtspconnection.c:214: error: `O_NONBLOCK' undeclared (first use in this
function)
rtspconnection.c:220: error: `EINPROGRESS' undeclared (first use in this
function)

If I'm not mistaken, that fcntl call (see also lines 139 and 140) can be
replaced on windows by:

ioctlsocket(fd, FIONBIO, &flags)

where flags is declared like that:

unsigned long flags;

To check the returned value of ioctlsocket : 

if (ioctlsocket(svr->fd, FIONBIO, &flags) == SOCKET_ERROR) { *** }


about line 220, EINPROGRESS is actually WSAEINPROGRESS, defined in winsock2.h.
So maybe a #define EINPROGRESS WSAEINPROGRESS just after including winsock2.h
is sufficient.

If you think that those modifications are correct, I can make a patch


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=446981.