[gstreamer-bugs] [Bug 447000] [id3demux] add support for reading license URL from WCOP tag

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=447000

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89867|none                        |needs-work
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
            Summary|[PATCH] id3demux support for|[id3demux] add support for
                   |reading license URL from    |reading license URL from
                   |WCOP tag                    |WCOP tag




------- Comment #3 from Tim-Philipp Müller  2007-06-13 09:37 UTC -------
Thanks for the patch.

Do you happen to have a sample file/tag with such a frame? (use 'head
--bytes=100k file.mp3 > tag.id3v2' to get the beginning of a file)


Couple of things I wonder about:

 - the 'is always encoded in ISO-8859-1' only applies to the WXXX frame,
   which we are explicitly not handling; it doesn't seem to apply to all
   the other 'W...' frames, if I read id3v2.4.0-frames.txt correctly   

 - but even if you were right, the code still needs to do ISO-8859-1 to
   UTF8 conversion, if I'm not mistaken (not that an URI should contain
   anything but ASCII, but still; also, I wouldn't be surprised if people
   actually did encode URIs in UTF-16 or whatever, regardless of the spec)

 - I wonder if it makes sense to introduce a new GST_TAG_LICENES_URI for
   that kindof thing, not sure. Need to check how we handle this for
   vorbis/flac etc.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=447000.