[gstreamer-bugs] [Bug 448278] [v4l2src] several issues in cvs

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=448278

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Alexander Eichner changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[v4l2src] tuner interface   |[v4l2src] several issues in
                   |implementation in current   |cvs
                   |cvs is broken               |




------- Comment #4 from Alexander Eichner  2007-06-19 20:56 UTC -------
I updated the description because it doesn't describe the real problem.

The attached patch solves these issues for me.
Description of the patch:

1. v4l2src->num_buffers is initialized with zero but the property has a minimum
value of GST_V4L2_MIN_BUFFERS. If the queue-size is not changed by the
application this would give an invalid argument error. The patch fixes this:
v4l2src->num-buffers is initialized to GST_V4L2_MIN_BUFFERS

2. the first ioctl call in gst_v4l2src_probe_caps_for_format (v4l2src_calls.c)
fails with a invalid argument error though VIDIOC_ENUM_FRAMESIZES is defined
the actual patch undefines these. But maybe the return value should checked and
if this is an error we should fallback to the old version?

3. The code for kernels < 2.6.19 in gst_v4l2src_probe_caps_for_format
(v4l2src_calls.c) sets the property range from 1 to GST_V4L2_MAX_SIZE.
The command ./gst-launch-0.10 v4l2src ! xvimagesink exits with an error because
the maximum texture size from xvimagesink is chosen but in my case this is
2046x2046 and this is to big for the saa7134 driver. The patch checks the size
with gst_v4l2src_get_size_limits


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=448278.