[gstreamer-bugs] [Bug 430682] multiqueue doesn't output data on unlinked pads properly

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Wed Jun 27 04:42:42 PDT 2007


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=430682

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.14




------- Comment #3 from Jan Schmidt  2007-06-27 11:42 UTC -------
Fixed in CVS:

2007-06-26  Jan Schmidt  <thaytan at noraisin.net>

        * plugins/elements/gstmultiqueue.c: (gst_multi_queue_init),
        (gst_single_queue_flush), (apply_segment), (apply_buffer),
        (gst_single_queue_push_one), (gst_multi_queue_loop),
        (gst_multi_queue_sink_activate_push), (gst_multi_queue_sink_event),
        (gst_multi_queue_src_activate_push), (wake_up_next_non_linked),
        (compute_high_id), (gst_single_queue_new):
        * plugins/elements/gstmultiqueue.h:
        Take the multiqueue lock when updating the fill level so we don't get
        confused.

        After applying a buffer or event on the src pad segment, make sure to
        call gst_data_queue_limits_changed() to get the data queue to unblock
        and check the filled state again.

        Rework the not-linked pad handling so the logic is that not-linked
        pads can push as fast as they like, but only so they never get
        ahead of any linked pads.

        * tests/check/elements/multiqueue.c: (mq_sinkpad_to_srcpad),
        (mq_dummypad_getcaps), (mq_dummypad_chain), (mq_dummypad_event),
        (run_output_order_test), (GST_START_TEST), (multiqueue_suite):

        Add a test to check that not-linked pads always stay behind
        linked pads.

        Fixes: #430682


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=430682.




More information about the Gstreamer-bugs mailing list