[gstreamer-bugs] [Bug 360246] [audioconvert] Optionally apply dithering

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=360246

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90786|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.14




------- Comment #27 from Sebastian Dröge  2007-06-28 20:36 UTC -------
Ok, committed:

2007-06-28  Sebastian Dröge  <slomo at circular-chaos.org>

        * gst/audioconvert/Makefile.am:
        * gst/audioconvert/audioconvert.c: (audio_convert_get_func_index),
        (check_default), (audio_convert_prepare_context),
        (audio_convert_clean_context), (audio_convert_convert):
        * gst/audioconvert/audioconvert.h:
        * gst/audioconvert/gstaudioconvert.c:
        (gst_audio_convert_dithering_get_type),
        (gst_audio_convert_ns_get_type), (gst_audio_convert_class_init),
        (gst_audio_convert_init), (gst_audio_convert_set_caps),
        (gst_audio_convert_set_property), (gst_audio_convert_get_property):
        * gst/audioconvert/gstaudioconvert.h:
        * gst/audioconvert/gstaudioquantize.c:
        (gst_audio_quantize_setup_noise_shaping),
        (gst_audio_quantize_free_noise_shaping),
        (gst_audio_quantize_setup_dither),
        (gst_audio_quantize_free_dither),
        (gst_audio_quantize_setup_quantize_func),
        (gst_audio_quantize_setup), (gst_audio_quantize_free):
        * gst/audioconvert/gstaudioquantize.h:
        Implement dithering and noise shaping in audioconvert. By default now
        TPDF dithering (and no noise shaping) will be used when converting
        from a higher bit depth to 20 bit depth or smaller, otherwise
        everything will be as it is now.
        For the last audioconvert in a pipeline it would make sense to
        use some kind of noise shaping, enabling it by default for all
        conversions would give undesired results though. Fixes #360246.
        * tests/check/elements/audioconvert.c: (setup_audioconvert),
        (GST_START_TEST):
        Adjust unit test for the new audioconvert.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=360246.