[gstreamer-bugs] [Bug 415627] [PLUGIN-MOVE] move equalizer to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=415627

  GStreamer | gst-plugins-bad | Ver: HEAD CVS


Christophe Dehais changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.dehais at gmail.com




------- Comment #2 from Christophe Dehais  2007-03-08 09:51 UTC -------
(In reply to comment #0)
> These things should be done before equalizer plugin can be moved from bad to
> good (besides the items mentioned in the moving-plugins list):
> 
> * add elements with fixed bands (equalizer3, equalizer10)
>   equalizer3: simple low,mid,high tone control
>   equalizer10: advanced eq for media players
> contrary to the current eq, this way frequency bands can have explicit labels
> (for the center frequency).

As said on bug #76522 the equalizer for rhythmbox is done in a way that it
won't take any advantage of having those elements. If they had existed when I
started hacking on it, I would have considered restricting the plugin to using
only the particular equalizer10 element and nothing else, but now the plugin
can parameterize the general equalizer element itself, so you can have any
number of bands you want.
Actually, I miss 2 things:
   * being able to retrieve the band frequencies. Would the GstChildProxy
mecanism allow this for the general version of the equalizer ?
   * having a mapping to dB units for the gain range values (instead of
[-1,1]). That's only for consistency with the ladspa equalizers.


> 
> * change the equalizer element to use GstChildProxy for the bands. this is the
> pattern we use for dynamic number of parameters. Using a value_array is
> plainful for the application side, the UI generation and additional components
> (like presets).
> 

That would surely be cleaner.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email