[gstreamer-bugs] [Bug 417420] [autoaudiosink] add "caps" property to filter sinks by caps

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=417420

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Tommi Myöhänen changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ext-tommi.myohanen at nokia.com




------- Comment #3 from Tommi Myöhänen  2007-03-12 15:16 UTC -------
(In reply to comment #2)
> Why 'originally'? Are you using a modified version of playbin? Where do the
> caps come from in your context (your modified playbin?)

Yes, playbin has been modified. It just passes src caps from decodebin2 to
autoaudiosink. It would be nice to use normal caps negotiation here instead of
a property, but as long as sink needs to be in same state (paused/playing) with
existing pipeline when linking, it doesn't work.

>  - I'd use gst_value_{set|get}_caps() instead of the boxed
>    functions (it's clearer and won't require changing when
>    GstCaps is changed to some other base type like
>    GstMiniObject)

Yes, let's do this.

>  - I think the property name should be more specific than
>    just "caps" (don't ask me what though)

How about "filter_caps"? Or "sink_candidate_filter_caps"?

>  - my gut feeling is that the state change check shouldn't
>    be skipped when filter caps are specified (you did that
>    to avoid the double state change, so that shouldn't be
>    necessary any longer, right?), ie. no specified caps
>    should result in the same behaviour as filter caps "ANY"
>    IMHO.

This is ok too.

Thanks for comments


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email