[gstreamer-bugs] [Bug 415001] Add a min-ptime property to the GstBaseRTPAudioPayload class

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=415001

  GStreamer | gst-plugins-base | Ver: HEAD CVS





------- Comment #5 from Tim-Philipp Müller  2007-03-15 09:20 UTC -------
Couple of general comments:

 - Olivier: please create patches with cvs diff -p next time, so that
   the function names appear in the diff. This makes them much easier
   to read.


 About the committed patch:

 - new core/base API should usually be reviewed/approved
   by a core developer before being committed.

 - the basertpaudiopayload->priv->disposed stuff is redundant

 - you need to chain up to the parent class in the dispose function

 - basertpaudiopayload->priv->adapter is created in the instance
   init function and exists during the entire life cycle of the
   payloader object - why is the code littered with

     if (basertpaudiopayload->priv->adapter)
       gst_adapter_foo(..)

    ?

 - you added this API in gstbasertpaudioplayload.h:

    GstFlowReturn
    gst_base_rtp_audio_payload_push (GstBaseRTPPayload * basepayload, 
        const guint8 * data, guint payload_len, GstClockTime timestamp);

   The first argument should probably be of type GstBaseRTPAudioPayload *


About the other patch:

 - the padding needs to be adjusted if you add fields to the structures


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email