[gstreamer-bugs] [Bug 421543] [GstPad] Doesn't check if pad accepts caps after caps change

[GStreamer (bugzilla.gnome.org)]

Do NOT reply to this via email (we are currently unable to handle email
responses and they WILL be discarded).

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=421543.
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

  GStreamer | gstreamer (core) | Ver: HEAD CVS


Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85120|0                           |1
        is obsolete|                            |




------- Comment #10 from Sebastian Dröge  2007-03-25 19:30 UTC -------
Created an attachment (id=85277)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=85277&action=view)
gstpad.diff

This patch fixes at least the case where the buffer caps != NULL.

For the buffer caps == NULL case some special magic has to be done it seems as
in the current code caps_changed is set if buffer caps != NULL and buffer caps
!= pad caps...

There should either be some checking in gst_pad_set_caps() or caps_changed
should be determined by a flag that is set whenever the pad's caps are changed
in set_caps and the old check...