[gstreamer-bugs] [Bug 420079] [audioconvert] Uses biased rounding which results in distortions

[GStreamer (bugzilla.gnome.org)]

Do NOT reply to this via email (we are currently unable to handle email
responses and they WILL be discarded).

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=420079.
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85252|none                        |committed
               Flag|                            |
         AssignedTo|slomo at circular-chaos.org    |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.13




------- Comment #13 from Sebastian Dröge  2007-03-27 12:46 UTC -------
Ok, committed...

2007-03-27  Sebastian Dröge  <slomo at circular-chaos.org>

        * gst/audioconvert/audioconvert.c:
        Add docs to the integer pack functions and implement proper
        rounding. Before we had rounding towards negative infinity, i.e.
        always the smaller number was taken. Now we use natural rounding,
        i.e. rounding to the nearest integer and to the one with the largest
        absolute value for X.5. The old rounding introduced some minor
        distortions. Fixes #420079
        * tests/check/elements/audioconvert.c: (GST_START_TEST):
        Fix one unit test that assumed the old rounding and added unit tests
        for checking signed/unsigned int16 <-> signed/unsigned int16 with
        depth 8, one for signed int16 <-> unsigned int16 and one for the new
        rounding from signed int32 to signed/unsigned int16.