[gstreamer-bugs] [Bug 437457] New: saving relocations for GstElementDetails

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=437457

  GStreamer | gstreamer (core) | Ver: HEAD CVS
           Summary: saving relocations for GstElementDetails
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


replacing this code:

static const GstElementDetails gst_identity_details =
GST_ELEMENT_DETAILS ("Identity",
    "Generic",
    "Pass data without modification",
    "Erik Walthinsen <omega at cse.ogi.edu>");
gst_element_class_set_details (gstelement_class, &gst_identity_details);

with

gst_element_class_set_details_simple (gstelement_class, "Queue",
    "Generic",
    "Simple data queue",
    "Erik Walthinsen <omega at cse.ogi.edu>");

and having this in e.g gstelement.c
void
gst_element_class_set_details_simple (GstElementClass * klass, gchar *longname,
  gchar *classification, gchar *description, gchar *author)
{
  const GstElementDetails details =
    GST_ELEMENT_DETAILS (longname, classification, description, author);

  g_return_if_fail (GST_IS_ELEMENT_CLASS (klass));

  __gst_element_details_copy (&klass->details, &details);
}

saves 4 relocations per GstElementDetails. You can check as below:
readelf -d /usr/lib/gstreamer-0.10/libgstcoreelements.so  | grep REL

For some background please read:
http://bugzilla.gnome.org/show_bug.cgi?id=337058


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=437457.