[gstreamer-bugs] [Bug 152864] [PATCH] GstAlsaMixer doesn't support signals

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=152864

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88097|none                        |needs-work
               Flag|                            |




------- Comment #21 from Tim-Philipp Müller  2007-05-15 13:29 UTC -------
(From update of attachment 88097)
>--- a/gst-libs/gst/interfaces/mixer.h
>+++ b/gst-libs/gst/interfaces/mixer.h
> 
>-#define GST_MIXER_TYPE(klass) (klass->mixer_type)
>+/* compatibility with version <= 0.10.12 */
>+#define GST_MIXER_TYPE(klass)  (GST_MIXER_IS_HARDWARE(klass) ? GST_MIXER_HARDWARE : GST_MIXER_SOFTWARE)
>+#define GST_MIXER_FLAGS(klass) (klass->flags)

This only maintains API, but not ABI, if I'm not mistaken.

> struct _GstMixerClass {
>   GTypeInterface klass;
> 
>-  GstMixerType mixer_type;
>+  GstMixerFlags flags;

This breaks ABI, I think.

I don't know if we actually need this new flag. I guess it depends on how we
solve the 'big picture' problem. If we added a new vfunc to return a monitoring
GSource then we could just add API to check if a particular mixer class
provides this or not. I'll try to solicit some more comments from other people.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=152864.