[gstreamer-bugs] [Bug 360246] [audioconvert] Optionally apply dithering

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=360246

  GStreamer | gst-plugins-base | Ver: HEAD CVS




------- Comment #25 from David Schleef  2007-05-15 19:30 UTC -------
The patch is hard to follow, I'll have to spend some time with the actual code.
 However, I've noticed:

 - the scale factor is still (1<<31)-1 instead of 1<<31

 - there's at least one place doing a float divide by a constant instead of a
multiply.  (Note that the compiler does the right thing for x = y*(1/12345.0))

 - Don't label things with "high quality" (e.g., NOISE_SHAPING_HQ), since
whether or not the quality is high depends on your standards.  Describe exactly
what it is, then add the modifier "(highest quality)" if appropriate.

 - Put references in the source for any research you've done, especially where
the filter coefficients came from.

After writing liboil, I find it very difficult to review mathematical code that
isn't written dirt-simple.  I'd encourage you to rewrite this in such a way
that there's an easy-to-understand reference implementation, and whatever
complicated optimized implementation, and some way to measure that they give
the same results.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=360246.