[gstreamer-bugs] [Bug 439390] New: fix up lame so we can control sample rate conversion

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=439390

  GStreamer | gst-plugins-ugly | Ver: HEAD CVS
           Summary: fix up lame so we can control sample rate conversion
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thomas at apestaart.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


After discussing with Wim, we agree two things should be done:

A) lame should have a property (e.g. allow-rate-conversion) that is set to TRUE
by default, allowing lame to resample internally.
If it is set to FALSE, and lame cannot satisfy keeping the sample rate constant
(because the bitrate doesn't match or filtercaps on either pad don't allow it)
it should error with not-negotiated.

B) lame should respect the filter caps on the src pad.  This is probably a
little more complicated to get right.  Again, not-negiotated if lame cannot
satisfy the src caps' rate.

Doing this would allow us to correctly handle cases where we want to generate
mp3 for playback in a Flash application, which only works correctly with
11.025/22.05/44.1, and makes other sample rates sound like smurf songs.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=439390.