[gstreamer-bugs] [Bug 412648] [filesink] reports wrong (byte) position after seeking

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=412648

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83463|none                        |committed
               Flag|                            |
  Attachment #83464|none                        |committed
               Flag|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.13




------- Comment #5 from Tim-Philipp Müller  2007-05-22 15:46 UTC -------
Thanks committed (also changed gnomevfssink to update the position variable
immediately after a successful seek so behaviour is consistent with filesink):

2007-05-22  Tim-Philipp Müller  <tim at centricular dot net>

        * plugins/elements/gstelements.c:
        * plugins/elements/gstfilesink.c: (gst_file_sink_do_seek),
        (gst_file_sink_get_current_offset):
        * plugins/indexers/gstindexers.c: (plugin_init):
          Use #ifdef for HAVE_XYZ for consistency.

        * tests/check/Makefile.am:
        * tests/check/elements/.cvsignore:
        * tests/check/elements/filesink.c: (setup_filesink),
        (cleanup_filesink), (GST_START_TEST), (filesink_suite):
          Add some unit tests for filesink.

2007-05-22  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Mark Nauwelaerts <manauw at skynet be>

        * plugins/elements/gstfilesink.c: (gst_file_sink_open_file),
        (gst_file_sink_query), (gst_file_sink_do_seek),
        (gst_file_sink_get_current_offset), (gst_file_sink_render):
        * plugins/elements/gstfilesink.h:
          Fix position reporting; rename data_written member to current_pos to
          reflect its real meaning (fixes #412648).



2007-05-22  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Mark Nauwelaerts <manauw at skynet be>

       * ext/gnomevfs/gstgnomevfssink.c: (gst_gnome_vfs_sink_init),
       (gst_gnome_vfs_sink_open_file), (gst_gnome_vfs_sink_handle_event),
       (gst_gnome_vfs_sink_query), (gst_gnome_vfs_sink_render):
       * ext/gnomevfs/gstgnomevfssink.h:
         Fix position reporting, especially after a seek (from upstream),
         see #412648.


2007-05-22  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/Makefile.am:
        * tests/check/elements/.cvsignore:
        * tests/check/elements/gnomevfssink.c: (setup_gnomevfssink),
        (cleanup_gnomevfssink), (GST_START_TEST), (gnomevfssink_suite):
          Add unit test for gnomevfssink seeking and position reporting for
          file:// URIs.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=412648.