If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=441393
GStreamer | gst-plugins-bad | Ver: HEAD CVS
Tim-Philipp Müller changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88841|none |reviewed
Flag| |
Severity|normal |enhancement
Status|UNCONFIRMED |NEEDINFO
------- Comment #2 from Tim-Philipp Müller 2007-05-26 11:56 UTC -------
Thanks for the patch; it does look like it needs a bit more work though, for
example:
- fix the FIXME in the directshow configure.ac check? Is there actually
a point to the AC_LINK_IFELSE there? (Does it test more than the
presence of those headers?
- the different headers thing needs to be sorted out somehow, ie. either
you check for both variants or pass magic cppflags so MingW checks for
headers in a case-insensitive way (surely that exists?)
(DShow.h vs. dshow.h and Rpc.h vs. rpc.h)
- would be nice if it didn't include cosmetic changes for
single files that are otherwise not modified
- not include iirequalizer modifications
- regarding gstdshowinterface.h: does MingW have 'bool'? if yes, would
that be equivalent?
- sys/dshowsrcwrapper/Makefile.am: what about the header files?
Did you make sure 'make distcheck' passes?
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=441393.