[gstreamer-bugs] [Bug 483400] mpegtsparse: PAT with version 0 incorrectly skipped by parser

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=483400

  GStreamer | gst-plugins-bad | Ver: HEAD CVS




------- Comment #1 from Wai-Ming Ho  2007-10-04 16:20 UTC -------
Created an attachment (id=96646)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=96646&action=view)
Patch mpegtspacketizer.c to initialize version_number to NOTSET

The patch sets the member section_version_number to an invalid version number
when the structure is first created. This allows PAT version 0 to be treated as
a new version when it is seen for the first time. This behavior will ensure
that mpegtspacketizer will process a version 0 PAT when it starts up for the
first time.

The patch also includes a review on mpegtsparse.c:720: We really should be
comparing (--patcount > 0) rather than (patcount-- == 1). This ensures that
values above 0 to be referenced programs. The pre-increment is required because
otherwise, we never remove any unreferenced programs as the old value of
patcount is used for the comparison.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=483400.