[gstreamer-bugs] [Bug 485343] Implement a wait_eos function in basesink

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=485343

  GStreamer | gstreamer (core) | Ver: 0.10.14

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com
  Attachment #96983|none                        |reviewed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.15




------- Comment #4 from Wim Taymans  2007-10-10 15:23 UTC -------
I changed it a little like this:

 - we can only go waiting for preroll when we actually need to (need_preroll)
   and this needs to be done before syncing against the clock (This method
could
   have been called in PAUSED, when the clock is not running).
 - return a GstFlowReturn. This is not yet very important right now.
 - check for BAD_TIME when sync was disabled, check for flushing so that we can
   return the right GstFlowReturn.
 - add some docs about whet lock needs to be taken before calling this
   function.

     Patch inspired by: Benoit Fouet <benoit dot fouet at purplelabs dot com>

       * libs/gst/base/gstbasesink.c: (gst_base_sink_wait_eos),
        (gst_base_sink_event):
       * libs/gst/base/gstbasesink.h:
        Add function to wait for EOS, subclasses can use this to correctly wait
        for devices to drain before performing the EOS logic. Fixes #485343.
        API: gst_base_sink_wait_eos()


Thanks!


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=485343.