[gstreamer-bugs] [Bug 491722] New: [playbin] regression: crash with external subtitles

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=491722

  GStreamer | gst-plugins-base | Ver: HEAD CVS
           Summary: [playbin] regression: crash with external subtitles
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Trying to use playbin with external subtitles crashes for me with CVS:

 gst-launch-0.10 playbin uri=file:///path/foo.avi  suburi=file:///path/foo.srt

in queue_threshold_reached() because get_active_group() returns NULL.

Everything works fine if I add a simple if(!group)return , but that doesn't
look like the right solution.

I wonder if queue_threshold_reached() should have been called at all given that
group_commit() has already been called via no_more_pads_full() from
new_decoded_pad_full().

I also wonder if queue_threshold_reached() shouldn't take the group lock before
calling _get_active_group()?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=491722.