[gstreamer-bugs] [Bug 430677] [audioconvert] does not preserve channel positions when fixating

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=430677

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86499|0                           |1
        is obsolete|                            |
  Attachment #97911|0                           |1
        is obsolete|                            |
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[PATCH] audioconvert does   |[audioconvert] does not
                   |not preserve channel        |preserve channel positions
                   |positions                   |when fixating
   Target Milestone|HEAD                        |0.10.15




------- Comment #6 from Tim-Philipp Müller  2007-10-31 18:33 UTC -------
I think we need something a bit more elaborate here, since there's no guarantee
the possible output caps have a fixed channel layout (it may be a list of
possible layouts), or -- in case that input and output have the same number of
channels -- that downstream can do the input channel layout:

 2007-10-31  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/audioconvert/gstaudioconvert.c: (find_suitable_channel_layout),
          (gst_audio_convert_fixate_channels), (gst_audio_convert_fixate_caps):
          Preserve channel layout when fixating the number of channels in the
          output caps, or make sure there's a suitable channel position layout
          set on the caps if required. Fixes #430677.

(Thijs: also, you probably meant to fixate first and only read the number of
output channels fixated to after that :)).

Please test and re-open if it doesn't work right.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=430677.