[gstreamer-bugs] [Bug 456573] allow dumping pipelines as dot graphs

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=456573

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #7 from Tim-Philipp Müller  2007-09-07 20:12 UTC -------
It's quite cool but I wonder why you use GST_DEBUG_* macros to dump it.  It
doesn't look particularly GST_DEBUG* related to me other than that it's useful
for debugging, among other things.  Also, having it as GST_DEBUG_* macro might
lead some people to believe that this macro can be used freely just like
GST_DEBUG, which probably wouldn't be a good idea, would it?

I also wonder if it should be part of libgstreamer, or if it shouldn't rather
be put in some external helper library, like pbutils or so.

Furthermore, I wonder if the _WITH_TS variant is really needed, or if the
normal dump function could just check with strstr() if there's a "%"
GST_TIME_FORMAT template in the filename and fill in the time.

Haven't looked at the implementation, since it doesn't interfere with anything
else.


In short, my suggestions:

   - turn the macros into full-fledged functions

   - either put the whole thing into gstutils.c or
      into a new pbutils sub-module

Others may disagree of course. :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=456573.