[gstreamer-bugs] [Bug 476514] [queue] Doesn't forward EOS event in all cases

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=476514

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #14 from Jan Schmidt  2007-09-14 10:18 UTC -------
(In reply to comment #12)
> Yep, adding the hack below to gstqueue.c makes the above pipeline work. Would
> be nice if someone with deeper knowledge about queue could look into this.
> 

EOS is a serialized event - in queue it is handled by the default: case, and
should be placed in the queue and output in correct serial order.

The problem from my perspective is wavparse returning UNEXPECTED when it hasn't
yet received EOS - the consequence as you've noted is that queue won't send
anything more.

Instead, I think wavparse should feel free to ignore any further data it
receives once it has seen what it thinks is the end of the file, but it should
definitely not take it upon itself to return UNEXPECTED - it should just pass
the EOS downstream, and let that shut the pipeline down.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=476514.