[gstreamer-bugs] [Bug 442065] floatcast.h includes config.h and might break other apps

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=442065

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89114|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.15




------- Comment #6 from Tim-Philipp Müller  2007-09-25 11:56 UTC -------
> Wouldn't it work if the application that uses floatcast.h includes config.h and
> in the macro docs we tell that the application that use those should check for
> the availability of lrint,lrintf ?

Yes, I think it's the best we can do for now:


   2007-09-25  Tim-Philipp Müller  <tim at centricular dot net>

        * gst-libs/gst/floatcast/floatcast.h:
          Don't include config.h in an installed public header, this
          might break compilation of applications that don't have such
          a header and doesn't necessarily do what it's supposed to do
          anyway (ie. check for the lrint/lrintf defines) (#442065).
          Add docs for the various macros and document how this header
          has to be used (link against libm, etc.); add a few FIXMEs;
          include math.h for non-c99 code path.  Based on patch by
          Jan Schmidt.


Not that anything actually seems to use those gst_cast_*() macros ...


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=442065.