[gstreamer-bugs] [Bug 545197] jackaudiosrc

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=545197

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115499|none                        |needs-work
               Flag|                            |




------- Comment #6 from Stefan Kost (gstreamer, gtkdoc dev)  2008-08-04 06:54 UTC -------
The patch needs some work :/
* it has formatting changes
* it has some comments fro the template plugin (see e.g. Makefile.am)
* there are changes to jackaudiosink.{c,h}:
* gstjackringbuffer.h implements a class that is inlucded in both src/sink
  - there should be a gstjackringbuffer.c with the implementation
* jackaudiosrc.{c,h} the naming is not according to the conventions
  GST_TYPE_JACKAUDIOSRC -> GST_TYPE_JACK_AUDIO_SRC
  GST_JACKAUDIOSRC -> GST_JACK_AUDIO_SRC
  ...

$ diffstat jacksrc.diff 
 Makefile.am          |   23 -
 gstjack.c            |   43 +
 gstjack.h            |   48 ++
 gstjackaudioclient.h |   33 -
 gstjackaudiosink.c   | 1167
++++++++++++++++++++++++---------------------------
 gstjackaudiosink.h   |   79 +--
 gstjackaudiosrc.c    |  815 +++++++++++++++++++++++++++++++++++
 gstjackaudiosrc.h    |  103 ++++
 gstjackbin.c         |    3 
 gstjackringbuffer.h  |   97 ++++


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=545197.