[gstreamer-bugs] [Bug 545501] Unable to get the parent of a GstSubBuffer

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=545501

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #6 from Thijs Vermeir  2008-08-05 09:26 UTC -------
Tim, I agree with you that we should have virtual functions for this. But I
think you can't add new virtual functions without breaking the ABI. So it is
not a solution for the 0.10 series. (or am I wrong in this?)

Option b) with the gst_buffer_get_parent_buffer is a hack because parent buffer
does not exists in the instance of a GstBuffer. But I proposed it because it is
the hack with the least impact. (only one extra function, easily removable when
we fix this for real with the virtual function in 0.11)

I prefer option a) for making the subbuffer public, like in the attached
patches. Because it does not change anything in the current behavior of
gstreamer core. and It makes it pretty easy for the sink to recover the lost
parent. I don't see a problem in making a class public that is already used and
provided to the elements. Are there disadvantages at making this public ?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=545501.