[gstreamer-bugs] [Bug 546328] fractions with G_MAXINT cause failure for fixation

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=546328

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com
 Attachment #115860|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.21




------- Comment #4 from Wim Taymans  2008-08-05 15:05 UTC -------
Something close to 320 x 240 at 30 fps seems like a good default. v4l2src seems
to want to negotiate to the highest possible video size with the highest
possible framerate which usually results in something too big and too slow and
too unusable.

Commited your patch after making a unit test for it that found a bug in the
code that I then also fixed.

        Patch by: Olivier Crete <tester at tester dot ca>

        * gst/gststructure.c:
        (gst_structure_fixate_field_nearest_fraction):
        Avoid overflows in fixation code when dealing with MAXINT values, which
        v4l2src seems to do.
        Fixes #546328.

        * tests/check/gst/gststructure.c: (GST_START_TEST):
        Make a unit test to check the fix.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=546328.