[gstreamer-bugs] [Bug 547835] tee release_request_pad while buffer_alloc racyness
GStreamer (bugzilla.gnome.org)
bugzilla-daemon at bugzilla.gnome.org
Fri Aug 15 10:02:09 PDT 2008
If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=547835
GStreamer | gstreamer (core) | Ver: HEAD CVS
Wim Taymans changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #116659|none |committed
Flag| |
Attachment #116661|none |committed
Flag| |
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|HEAD |0.10.21
------- Comment #10 from Wim Taymans 2008-08-15 17:02 UTC -------
I fixed it a little with an extra variable, there was still a race where the
pad would be removed and shut down first before the pad_alloc was called.
Patch by: Ole André Vadla Ravnås <ole.andre.ravnas at tandberg com>
* plugins/elements/gsttee.c: (gst_tee_finalize), (gst_tee_init),
(gst_tee_request_new_pad), (gst_tee_release_pad),
(gst_tee_find_buffer_alloc), (gst_tee_buffer_alloc):
* plugins/elements/gsttee.h:
Protect pad_alloc with a new lock so that we can be sure that nothing
is
performing a pad_alloc when removing the pad. Fixes #547835.
* tests/check/elements/tee.c: (buffer_alloc_harness_setup),
(buffer_alloc_harness_teardown), (app_thread_func),
(final_sinkpad_bufferalloc), (GST_START_TEST), (tee_suite):
Added testcase for shutdown race.
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547835.
More information about the Gstreamer-bugs
mailing list