[gstreamer-bugs] [Bug 548394] basesink should ignore EOS during flushing

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Tue Aug 19 01:54:44 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=548394

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com
 Attachment #116935|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.21




------- Comment #2 from Wim Taymans  2008-08-19 08:54 UTC -------
Thanks, I slightly modified the patch to drop _all_ events in this case since
it is possible that the segment event also causes a release of the
PREROLL_LOCK.

Ideally, the subclass doing the _wait_eos() call should have returned FALSE
from the event handler if after releasing the PREROLL_LOCK the sink is
flushing.

        Based on patch by: Jason Zhao <e3423c at motorola dot com>

        * libs/gst/base/gstbasesink.c: (gst_base_sink_render_object):
        When the subclass event handler releases the PREROLL_LOCK, we could be
        in the flushing state and we have to ignore the event. Fixes #548394.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=548394.




More information about the Gstreamer-bugs mailing list