[gstreamer-bugs] [Bug 564115] [PATCH] fbdev: remove endianness swapping

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=564115

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Luotao Fu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |l.fu at pengutronix.de




------- Comment #3 from Luotao Fu  2008-12-18 15:57 UTC -------
Thx for your comment.
Like I said, I was still quite not sure about the color masking in gstreamer.
e.g. the rmask ist built in fbdev with
((1 << fbdevsink->varinfo.red.length) - 1) << fbdevsink->varinfo.red.offset;
Say if we have RGB888 with red.length = 8 and red.offset = 16 in varinfo.
fbdevsink turns after calling swapendian() into BGR888. I quite don't get it
what for.

Besides, swapendian() doesn't work with masks with are not aligned on byte
edges.
I'm hacking on rgb666 support. Which means that the rmask is 0x000f3000.
swapendian() turns it into 0x00300f00, which doesn't make lot of sense.

Cheers
Luotao Fu


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=564115.