[gstreamer-bugs] [Bug 516509] New: gstid3v2mux.cc build failure on Solaris, CFLAGS not valid for CXX

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516509

  GStreamer | gst-plugins-good | Ver: HEAD CVS
           Summary: gstid3v2mux.cc build failure on Solaris, CFLAGS not
                    valid for CXX
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: mooney at dogbert.cc.ndsu.nodak.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


I'm building gst-plugins-good on x86_64-sun-solaris2.10 with the Sun Workshop
12 compilers (C and C++), OS and compilers are completely up to date with
patches.

I get a compile failure for gstid3v2mux.cc:

/bin/bash ../../libtool --tag=CXX   --mode=compile CC -DHAVE_CONFIG_H -I.
-I../..   -I/local/include/X11 -I/local/include -I/local/gnu/include/X11
-I/local/gnu/include -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2  
-I../../gst-libs -I../../gst-libs -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2  
-errwarn=%all,no%E_EMPTY_DECLARATION,no%E_STATEMENT_NOT_REACHED,no%E_ARGUEMENT_MISMATCH,no%E_MACRO_REDEFINED
 -g    -I/local/include/taglib   -xO2 -library=stlport4 -library=Crun
-D__func__=\"unknown\" -KPIC -m64 -xtarget=native -xarch=native -c -o
libgsttaglib_la-gstid3v2mux.lo `test -f 'gstid3v2mux.cc' || echo
'./'`gstid3v2mux.cc
 CC -DHAVE_CONFIG_H -I. -I../.. -I/local/include/X11 -I/local/include
-I/local/gnu/include/X11 -I/local/gnu/include -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2
-I../../gst-libs -I../../gst-libs -D_REENTRANT -D_PTHREADS
-I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2
-errwarn=%all,no%E_EMPTY_DECLARATION,no%E_STATEMENT_NOT_REACHED,no%E_ARGUEMENT_MISMATCH,no%E_MACRO_REDEFINED
-g -I/local/include/taglib -xO2 -library=stlport4 -library=Crun
-D__func__=\"unknown\" -KPIC -m64 -xtarget=native -xarch=native -c
gstid3v2mux.cc  -DPIC
Bad value 'E_EMPTY_DECLARATION' for flag '-errwarn' for
'/opt/SUNWspro/prod/bin/ccfe'.
Bad value 'E_STATEMENT_NOT_REACHED' for flag '-errwarn' for
'/opt/SUNWspro/prod/bin/ccfe'.
Bad value 'E_ARGUEMENT_MISMATCH' for flag '-errwarn' for
'/opt/SUNWspro/prod/bin/ccfe'.
Bad value 'E_MACRO_REDEFINED' for flag '-errwarn' for
'/opt/SUNWspro/prod/bin/ccfe'.
4 Error(s) detected.


This happens because (unlike gcc/g++), flags that are valid for the C compiler
(e.g. -errwarn =%all,no%E_EMPTY_DECLARATION,etc.... ) are not necessarily valid
for the C++ compiler.  gstid3v2mux.cc is being compiled by the C++ compiler,
but it's being passed GST_CFLAGS, which includes ERROR_CFLAGS, which is where
the offending command line argument is coming from.  It's easy to imagine that
some of the other *_CFLAGS that go into GST_CFLAGS might also be valid for a
particular C compiler but not its C++ counterpart.

The best fix would be to have *_CXXFLAGS variants of all ERROR_CFLAGS,
DEBUG_CFLAGS, PROFILE_CFLAGS, DEPRECATED_CFLAGS, etc, and then use those when
building any C++ source files.  This will require more tests at configure time,
though.

One workaround is to use "make ERROR_CFLAGS=" in ext/taglib.  That gets me by
this problem.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516509.