[gstreamer-bugs] [Bug 516395] gst_buffer_create_sub does not copy flags

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516395

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Stefan Kost (gstreamer, gtkdoc dev) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105215|reviewed                    |none
               Flag|                            |




------- Comment #4 from Stefan Kost (gstreamer, gtkdoc dev)  2008-02-14 17:29 UTC -------
(I also started typing at the same time. :/ )

It currently does the same as in gst_buffer_make_metadata_writable() where it
creates a sub_buffer too. If we can conclude I like to remove the special case
handling in gst_buffer_make_metadata_writable().

GST_BUFFER_FLAG_READONLY
should be set and is set in subbuffer_init already

GST_BUFFER_FLAG_PREROLL
should be copied too, if we peel off some bytes and send the subbuffer further
it should keep the flag

GST_BUFFER_FLAG_DISCONT
same here, keep the flag 

GST_BUFFER_FLAG_IN_CAPS
it would be good to explain in the docs, what the use case is here. I cleared
the flag in the patch as its cleared in _make_metadata_writable() already for a
reason.

GST_BUFFER_FLAG_GAP
should be copied as a subbuffer inherits this property

GST_BUFFER_FLAG_DELTA_UNIT
copy too, if the unit can not be decoded independently, how should it not be  
the same for even a subbuffer?

Btw. the (core) test suite runs fine with the patch. So if its not good to do
it, then we don't cover those cases yet.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516395.