[gstreamer-bugs] [Bug 518042] New: gst_pad_push() return value is ignored

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=518042

  GStreamer | gst-openmax | Ver: HEAD CVS
           Summary: gst_pad_push() return value is ignored
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-openmax
        AssignedTo: felipe.contreras at nokia.com
        ReportedBy: ext-tommi.myohanen at nokia.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


In gstomx_base_filter.c there is a separate output_thread that calls
push_buffer() that in turn calls gst_pad_push(). The return value of
gst_pad_push() is not taken, and _chain() function (almost) always returns
GST_FLOW_OK.

Instead, the output_thread should save this GstFlowReturn value and _chain()
should use it as a return value. This way the downstream _push() return value
gets propagated upstream, e.g. when pipeline is set to NULL. Currently the
parser element just keeps on pushing frames to decoder, since chain incorrectly
returns GST_FLOW_OK even the gst_pad_push() has returned GST_FLOW_WRONG_STATE.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=518042.