[gstreamer-bugs] [Bug 506549] fbdevsink patch

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=506549

  GStreamer | gst-plugins-bad | Ver: HEAD CVS




------- Comment #7 from David Schleef  2008-01-06 23:01 UTC -------
Some comments:

* Please move declarations to the top of blocks.  It's the gstreamer style.

* Use the glib macros for endianness changing.

* Add a test for big endian, and a g_warning() asking the BE user to report
feedback on whether it works or not.

* Please add checks for failed opens and mmaps in gst_fbdevsink_stop()


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.