[gstreamer-bugs] [Bug 510187] gst_plugin_register_static() API review and GST_PLUGIN_DEFINE_STATIC deprecation

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=510187

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103223|0                           |1
        is obsolete|                            |




------- Comment #16 from Tim-Philipp Müller  2008-01-20 12:18 UTC -------
Created an attachment (id=103251)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=103251&action=view)
updated patch

The unit test just makes sure that the old code path via
_gst_element_register_static() still works and doesn't do anything dumb (like
assuming a wrong function signature when using g_list_foreach).

e.g if you change
    _static_plugins[_num_static_plugins - 1] = *desc;
to
    _static_plugins[_num_static_plugins] = *desc;

it will fail at least under valgrind.


If the compiler doesn't support constructors, things should still compile,
although I'm not sure if that's true for -Wall -Werror. I've changed the test
to only test this stuff with gcc for now, since that's the only compiler for
which we define GST_GNUC_CONSTRUCTOR.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=510187.