[gstreamer-bugs] [Bug 510354] post GST_MESSAGE_STRUCTURE_CHANGE when linking and unlinking pads

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=510354

  GStreamer | gstreamer (core) | Ver: HEAD CVS




------- Comment #4 from Ole André Vadla Ravnås  2008-01-24 23:30 UTC -------
Created an attachment (id=103689)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=103689&action=view)
Updated patch.

I ran into the issue described by this bug and tried the original patch, but
still hit the same issue. After debugging I came to the conclusion
described by Wim.

This patch builds on the original patch but uses a start/stop sequence
before/after the changes are made. I was able to reproduce the race quite
reliably in less than 20 full-duplex a/v calls with rtpmanager before this
patch
(all inside one process using the loopback interface, so things get quite
racy).
Have not yet been able to reproduce with 100 call-setups. Will keep pounding
and
report back if I hit it again.

Would it be preferable to have GST_MESSAGE_STRUCTURE_CHANGE_{START,DONE}
instead
of one message for both by the way? (To follow the same pattern as the other
messages that are sequenced.)
Or alternatively something shorter like GST_MESSAGE_RESTRUCTURE_{START,DONE},
which as an added bonus means not having to re-indent all the other entries'
equal-signs and make for a huge diff. :)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=510354.