[gstreamer-bugs] [Bug 512578] New: gst_tag_setter_merge_tags can mess up with KEEP_ALL merge mode

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=512578

  GStreamer | gstreamer (core) | Ver: HEAD CVS
           Summary: gst_tag_setter_merge_tags can mess up with KEEP_ALL
                    merge mode
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: mail at renestadler.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


gst_tag_setter_merge_tags unconditionally copies over the given tag list if the
tag setter's list was unset before.  This is wrong for GST_TAG_MERGE_KEEP_ALL,
which is essentially a no-op.

Attaching test suite additions and fix.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=512578.