[gstreamer-bugs] [Bug 537675] rtp vorbis/theora payloader static caps don't specify delivery method

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Fri Jun 13 02:39:43 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=537675

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com
 Attachment #112650|none                        |committed
               Flag|                            |




------- Comment #5 from Wim Taymans  2008-06-13 09:39 UTC -------
Not quite right, for theoradepay, we have a mandatory deliver-method property
but we cannot enforce it in caps because it contains ANY strings so we can't
add it. Since we accidentally only support inline, we add only this
delivery-method to the caps.

For vorbis, the property is optional, so it must not be added to the caps. I
removed the check in the setcaps function to make the delivery-method
mandatory.

I reversed strcmp checks, too.

        Patch by: Olivier Crete <tester at tester dot ca>

        * gst/rtp/gstrtptheoradepay.c: (gst_rtp_theora_depay_setcaps):
        Make the delivery-method mandatory on the caps and only accept inline
        for now.
        Reverse strcmp checks for delivery-method.

        * gst/rtp/gstrtpvorbisdepay.c: (gst_rtp_vorbis_depay_setcaps):
        Make delivery method optional when parsing caps and note this in the
        caps.
        Reverse strcmp checks for delivery-method.

        * gst/rtp/gstrtpvorbispay.c:
        Update a comment to note that the delivery-method is optional,
        Fixes #537675.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=537675.




More information about the Gstreamer-bugs mailing list