[gstreamer-bugs] [Bug 518940] [playbin2] make _get_*_tags() match vfuncs prototype in class structure

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=518940

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
  BugsThisDependsOn|518934                      |
 Attachment #106037|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|Ensure gst-plugins-base     |[playbin2] make
                   |compilation if #518934 is   |_get_*_tags() match vfuncs
                   |accepted                    |prototype in class structure
   Target Milestone|HEAD                        |0.10.18




------- Comment #3 from Tim-Philipp Müller  2008-03-02 18:43 UTC -------
This seems to be the right thing to do regardless:

 2008-03-02  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: José Alburquerque <jaalburqu svn gnome org>

        * gst/playback/gstplaybin2.c:
          Make the function signature of the _get_*_tags() functions match
          the signature of the vfuncs they implement, ie. return a
          GstTagList rather than a GstStructure, which is more correct,
          even if one is typedef'ed to the other (#518940).


Thanks for the patch!


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=518940.