[gstreamer-bugs] [Bug 516649] [v4l2src] tries to VIDIOC_S_PARM without checking capabilities

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=516649

  GStreamer | gst-plugins-good | Ver: HEAD CVS

William M. Brack changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wbrack at mmm.com.hk




------- Comment #3 from William M. Brack  2008-03-16 16:35 UTC -------
I believe this patch is not correct. The statement
  if (v4l2src->v4l2object->vcap.capabilities & V4L2_CAP_TIMEPERFRAME)
is in error, because vcap is a v4l2_captureparm structure, whereas the flag
V4L2_CAP_TIMEPERFRAME is only present in a v4l2_capability structure.  You may
wish to look at the corresponding part of the proposed patch in bug #520092 to
see how (I believe) this may be done correctly.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=516649.