[gstreamer-bugs] [Bug 523806] New: Should use G_PARAM_STATIC_(NAME|NICK|BLURB) when possible

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Sat Mar 22 01:10:12 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=523806

  GStreamer | gstreamer (core) | Ver: HEAD CVS
           Summary: Should use G_PARAM_STATIC_(NAME|NICK|BLURB) when
                    possible
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hi,
currently we don't use G_PARAM_STATIC_(NAME|NICK|BLURB) anywhere when
installing a property. When using string literals or static strings this would
save use one allocation and one free for every string.

Does anybody see problems with this? For the docs see
http://library.gnome.org/devel/gobject/unstable/gobject-GParamSpec.html#GParamFlags


Also I would propose to add

#ifndef G_PARAM_STATIC_STRINGS
#define G_PARAM_STATIC_STRINGS (G_PARAM_STATIC_NAME | G_PARAM_STATIC_NICK |
G_PARAM_STATIC_BLURB)
#endif

as for most cases all 3 strings should be static and G_PARAM_STATIC_STRINGS was
added to glib with 2.13 (and we will depend only on 2.12 in a few days).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=523806.




More information about the Gstreamer-bugs mailing list