[gstreamer-bugs] [Bug 523985] New: [PATCH] [identity] meta-writes buffers without meta-writable check

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=523985

  GStreamer | gstreamer (core) | Ver: 0.10.18
           Summary: [PATCH] [identity] meta-writes buffers without meta-
                    writable check
           Product: GStreamer
           Version: 0.10.18
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: manauw at skynet.be
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


In single-segment or data-rate "mode", identity modifies time metadata of
passing buffers.  As identity configures basetransform for passthrough mode, no
preparation of input buffers is performed, and so buffer metadata may be
modified without _is_metadata_writable verification.

Rather, it seems that identity should not use basetransform in passthrough
mode, but in always_in_place mode and implement a _prepare_output_buffer.
In fact, identity is given as a use-case example for such behaviour in
basetransform documentation, so something is not ok either way ...


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=523985.