[gstreamer-bugs] [Bug 531166] New: MDVD Seek issue + patch

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=531166

  GStreamer | gst-plugins-base | Ver: 0.10.19
           Summary: MDVD Seek issue + patch
           Product: GStreamer
           Version: 0.10.19
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tsalacinski at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: 2.21/2.22
   GNOME milestone: Unspecified


Hello,

As you may know, seeking the movie with MicroDVD subtitles will make the subs
disappear for few seconds. This patch will make the subtitles work great - like
in MPlayer, Xine or FFDShow (the subs are shown instantly and GST is not slowed
down). Actually, it will make GSTreamer the best media framerowk for these
subs, because it supports italic/bold text, right now the only issue is
seeking. Here it is:

434,435c434,439
< 
<   if (!in_seg) { return NULL; }
---
>   if (in_seg) {
>     state->start_time = clip_start;
>     state->duration = clip_stop - clip_start;
>   } else {
>     return NULL;
>   }

Tested with few subtitle files, and it works ok. I would like to ask someone to
test it:) If you want to download the patch file, go here:

http://dp0154.debowypark.waw.pl/gst-sub-patch.diff

I am working on TMPlayer subtitle parser patch too, but AFAIK you prefer to
open a new bug, so I'm doing it.

Cheers,
and thanks for GStreamer,
Tomasz Sałaciński


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=531166.