[gstreamer-bugs] [Bug 530962] [subparse] parses only every second line of TMPlayer subtitle

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=530962

  GStreamer | gst-plugins-base | Ver: 0.10.19

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|t.i.m at zen.co.uk             |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.20




------- Comment #4 from Tim-Philipp Müller  2008-05-03 16:18 UTC -------
The parsing issue should be fixed in CVS now:

2008-05-03  Tim-Philipp Müller  <tim.muller at collabora co uk>

        * tests/check/elements/subparse.c: (do_test),
          (test_tmplayer_style3b), (subparse_suite):
          Add unit test for the tmplayer variant from bug #530962.

2008-05-03  Tim-Philipp Müller  <tim.muller at collabora co uk>

        * gst/subparse/gstsubparse.c: (handle_buffer),
          (gst_sub_parse_sink_event):
        * gst/subparse/tmplayerparse.c: (tmplayer_process_buffer),
          (tmplayer_parse_line):
          Fix parsing of tmplayer subtitle variant where every single line
contains
          text and there isn't an empty line after each line to determine the
          duration (#530962). Improve EOS handling for tmplayer subtitles a bit
by
          making sure that we push out the last line of text without a duration
if
          there's still text left in the buffer at the end.

I've tried your patch, but it makes all the tmplayer checks in the unit test
fail, and I couldn't really be bothered to investigate since I already had a
fix myself, sorry.

If you want support for italics, please file a separate bug for that (and if
you attempt a patch it would be preferably to base it on the current code or at
least code that passes all the unit tests; also, text within pango markup will
need to be escaped).


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=530962.