[gstreamer-bugs] [Bug 526768] Basetransform bufferalloc passing through to easily

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=526768

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110515|none                        |committed
               Flag|                            |
 Attachment #110519|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.20




------- Comment #7 from Sebastian Dröge  2008-05-08 06:20 UTC -------
2008-05-08  Sebastian Dröge  <slomo at circular-chaos.org>

        Based on a patch by: Sjoerd Simons <sjoerd at luon dot net>

        * libs/gst/base/gstbasetransform.c:
        (gst_base_transform_buffer_alloc):
        Don't passthrough buffer allocation too easily if the caps change.
        This breaks when working in passthrough mode and upstream changes 
        it's caps. Fixes bug #526768.

2008-05-08  Sebastian Dröge  <slomo at circular-chaos.org>

        Patch by: Sjoerd Simons <sjoerd at luon dot net>

        * gst/audioresample/gstaudioresample.c: (gst_audioresample_init):
        Let audioresample use the buffer allocation of basetransform instead
        of it's own stuff.

        * tests/check/elements/audioresample.c: (alloc_only_48000),
        (GST_START_TEST), (audioresample_suite):
        Add unit test for the recent basetransform bugfix, where upstream
        changes caps to something that can't be passed through anymore.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=526768.