[gstreamer-bugs] [Bug 526768] Basetransform bufferalloc passing through too easily

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=526768

  GStreamer | gstreamer (core) | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110754|none                        |committed
               Flag|                            |
 Attachment #110755|none                        |needs-work
               Flag|                            |




------- Comment #15 from Sebastian Dröge  2008-05-13 07:10 UTC -------
Sjoerd, your updated unit test runs fine even without your new patch. It
doesn't trigger the bug that Tim found it seems...

Committed the other part though as it's correct and fixes Tim's bug:


2008-05-13  Sebastian Dröge  <slomo at circular-chaos.org>

        Patch by: Sjoerd Simons <sjoerd at luon dot net>

        * libs/gst/base/gstbasetransform.c:
        (gst_base_transform_buffer_alloc):
        Check the caps of the buffer returned by gst_pad_alloc_buffer() and
        fall back to default negotiation in the chain function if the caps
        are different from what was requested. Fixes bug #526768.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=526768.