[gstreamer-bugs] [Bug 520885] directdrawsink has some issues

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Tue May 13 06:44:01 PDT 2008


If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=520885

  GStreamer | gst-plugins-good | Ver: HEAD CVS

Ole André Vadla Ravnås changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106731|none                        |committed
               Flag|                            |
 Attachment #106732|none                        |committed
               Flag|                            |
 Attachment #106733|none                        |committed
               Flag|                            |
 Attachment #106735|none                        |committed
               Flag|                            |
 Attachment #106739|none                        |committed
               Flag|                            |
 Attachment #110517|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.9




------- Comment #11 from Ole André Vadla Ravnås  2008-05-13 13:44 UTC -------
2008-05-07  Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        patch by: Haakon Sporsheim <haakon.sporsheim at tandberg com>

        * sys/directdraw/gstdirectdrawsink.c (gst_directdraw_sink_setup_ddraw):
          Do IDirectDrawClipper_SetHWnd() if the window ID has already been
          set after creating the clipper.

2008-05-07  Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        patch by: Haakon Sporsheim <haakon.sporsheim at tandberg com>

        * sys/directdraw/gstdirectdrawsink.c (gst_directdraw_sink_show_frame):
          Added checking of surface lost case after an unsuccessful
          IDirectDrawSurface7_Lock() call.
          If surface is lost, return GST_FLOW_OK.

2008-05-07  Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        patch by: Haakon Sporsheim <haakon.sporsheim at tandberg com>

        * sys/directdraw/gstdirectdrawsink.c (gst_directdraw_sink_show_frame,
          WndProc, gst_directdraw_sink_window_thread):
          Improved Windows message loop and fixed window destruction issue.
          When the window which DirectDraw is rendering to is destroyed, the
          render/show_frame function will return GST_FLOW_ERROR.
          Partially fixes #520885.

2008-05-07  Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        patch by: Haakon Sporsheim <haakon.sporsheim at tandberg com>

        * sys/directdraw/gstdirectdrawsink.c (gst_directdraw_sink_set_caps):
          Fixed mid stream resolution change bug, the offscreen surface is now
          released when set_caps is called.
          Partially fixes #520885.

2008-05-07  Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        * sys/directdraw/gstdirectdrawsink.c
          (gst_directdraw_sink_buffer_alloc):
          Make it so that gst_directdraw_sink_buffer_alloc uses the right
          width/height.

          Especially when looking through the pool of buffers, make sure that
          the width/height of caps is used instead of the already negotiated
          dimensions.
          For example if a buffer with different caps is requested, i.e.
          higher resolution, the caller would get a buffer with the old
          dimensions and thus corrupt the heap.

2008-05-07  Ole André Vadla Ravnås  <ole.andre.ravnas at tandberg com>

        * sys/directdraw/gstdirectdrawsink.c
          (gst_directdraw_sink_buffer_alloc):
          Clear the flags on recycled buffers from buffer_alloc.
          Partially fixes #520885.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=520885.




More information about the Gstreamer-bugs mailing list