[gstreamer-bugs] [Bug 454151] SPC plugin enhancements (patch)

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=454151

  GStreamer | gst-plugins-bad | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org
  Attachment #91288|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.8




------- Comment #2 from Sebastian Dröge  2008-05-20 09:02 UTC -------
Thanks, committed your patch with some minor changes:
  - used GST_SECOND and GST_MSECOND instead of large integer constants
everywhere
  - no // comments
  - correctly reference the taglist (i.e. not taking another reference before
posting it by creating an event from it)
  - check values before passing the to g_date_new_dmy()

2008-05-20  Sebastian Dröge  <slomo at circular-chaos.org>

        Patch by: Brian Koropoff <brianhk at cs dot washington dot edu>

        * ext/spc/Makefile.am:
        * ext/spc/gstspc.c: (gst_spc_dec_class_init),
        (gst_spc_dec_src_query_type), (gst_spc_dec_init),
        (gst_spc_dec_dispose), (gst_spc_dec_sink_event),
        (gst_spc_duration), (gst_spc_fadeout), (gst_spc_dec_src_event),
        (gst_spc_dec_src_query), (spc_play), (spc_setup):
        * ext/spc/gstspc.h:
        * ext/spc/tag.c: (spc_tag_is_extended), (spc_tag_is_text_format),
        (spc_tag_is_present), (spc_tag_unpack_date), (spc_tag_clear),
        (spc_tag_get_info), (spc_tag_free):
        * ext/spc/tag.h:
        Add support for some essential features like seeking, reading song
        duration and extended tags. Fixes bug #454151.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=454151.