[gstreamer-bugs] [Bug 533817] [audioconvert] Can't use default 7 channel layout / only support for a limited number of layouts

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=533817

  GStreamer | gst-plugins-base | Ver: HEAD CVS

Sebastian Dröge changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|slomo at circular-chaos.org    |gstreamer-
                   |                            |bugs at lists.sourceforge.net
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.20




------- Comment #7 from Sebastian Dröge  2008-05-29 11:34 UTC -------
2008-05-29  Sebastian Dröge  <slomo at circular-chaos.org>

        * gst-libs/gst/audio/multichannel.c:
        (gst_audio_check_channel_positions),
        (gst_audio_set_structure_channel_positions_list),
        (gst_audio_fixate_channel_positions):
        Allow rear center together with rear left/right and other previously
        conflicting channel positions. The reason why they weren't allowed
        was the channel mixing implementation in audioconvert.
        Also take this into account when fixing channel layouts.

        Allow setting channel positions for 1/2 channels when using
        gst_audio_set_structure_channel_position().

        * gst/audioconvert/gstchannelmix.c:
        (gst_channel_mix_fill_compatible), (gst_channel_mix_detect_pos),
        (gst_channel_mix_fill_one_other), (gst_channel_mix_fill_others),
        (gst_channel_mix_fill_special), (gst_channel_mix_fill_matrix):
        Major rewrite of the channel mixing.

        We now allow previously conflicting channel positions to appear
        together (rear center and rear left/right for example).
        Fixes bug #533817.

        Rework the way channels are mixed together to take more possible
        channel positions into account, properly mix from/to side channels
        and don't assume that either center, left&right or nothing of a
        specific position is available anymore.

        * tests/check/elements/audioconvert.c: (GST_START_TEST):
        Adjust unit tests with non-standard 1/2 channel layouts to the more
        correct new behaviour.

        Add a unit test for 5.1->Stereo downmixing.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=533817.